Prevent cluster groups from being deleted when referenced by a projects' configuration #15119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tomponline
reviewed
Mar 10, 2025
tomponline
requested changes
Mar 10, 2025
Whoopsie 😆 Thank you CodeQL 🙏 Not sure how I convinced myself that this was ok... |
markylaing
force-pushed
the
cluster-group-used-by
branch
2 times, most recently
from
bac19b8 to
2e939e5
Compare
tomponline
reviewed
Mar 14, 2025
tomponline
reviewed
Mar 14, 2025
tomponline
reviewed
Mar 14, 2025
markylaing
force-pushed
the
cluster-group-used-by
branch
from
2e939e5 to
c78bd05
Compare
|
Static analysis failure |
Signed-off-by: Mark Laing <[email protected]> # Conflicts: # doc/api-extensions.md # shared/version/api.go
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
This duplicates `(*cluster.ClusterGroup).ToAPI`. Signed-off-by: Mark Laing <[email protected]>
This function queries for projects that have the group name present in the value for the config key `restricted.cluster.groups`. Then it parses the config value properly to check for an exact match. Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
When calling `make` we should have the form:
make([]<type>, 0,<expected_length>)
and then append to it. Otherwise we risk having uninitialised elements
(e.g. by accidentally appending instead).
Signed-off-by: Mark Laing <[email protected]>
This includes a small refactor of `GET /1.0/cluster/groups` where the handler was unnecessarily iterating over the list of groups twice. Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
…ced by a project. Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
cluster-group-used-by
branch
from
c78bd05 to
9c38fc5
Compare
Fixed. |
tomponline
added a commit
that referenced
this pull request
Apr 15, 2025
Follow up to #15119 Cluster group used-by URLs we're not being filtered by what the caller is able to view. This allowed restricted users to see the URLs of projects that they do not have access to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API extension
clustering_groups_used_byand adds aUsedByfield toapi.ClusterGroup. On GET requests, theUsedByURLs are projects that contain the cluster group inrestricted.cluster.groups. DELETE requests will fail if the cluster group is used by a project.Closes #15118