CLI: Add lxc file completions and fix lxc profile copy completions (from Incus)
#14749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
force-pushed
the
file-push-pull-completions
branch
from
bb4b0a9 to
1f4c0e1
Compare
simondeziel
reviewed
Jan 6, 2025
kadinsayani
force-pushed
the
file-push-pull-completions
branch
2 times, most recently
from
1f82f6a to
9f26397
Compare
MusicDin
reviewed
Jan 7, 2025
kadinsayani
force-pushed
the
file-push-pull-completions
branch
from
9f26397 to
d52403e
Compare
The completion functions for instance and remote names now only return names prefixed by the string to be completed. This allows the caller of these functions to improve their decisions about their own completion behaviour. Signed-off-by: montag451 <[email protected]> (cherry picked from commit 42abaca45508aeab25f99da170e87101b2a327ab) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
This commit improves completions for `lxc file push|pull` Signed-off-by: montag451 <[email protected]> (cherry picked from commit d09af5317ae61c8557ed95caae144bcb88d74acb) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: montag451 <[email protected]> (cherry picked from commit 237fdcec2fba6cb34f5519c16cdc4e48d6226d8f) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: montag451 <[email protected]> (cherry picked from commit 09b3ebde479eeee6595a10c1f6e091940e231b1c) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: montag451 <[email protected]> (cherry picked from commit f541396da8b76583fa11c82d6eb3eb25f37a81e5) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: montag451 <[email protected]> (cherry picked from commit 65178013f600f194d02a5d7e5d20ce0d518825fd) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: montag451 <[email protected]> (cherry picked from commit 28da5dabf6ebe9de1ad1e2f3412012b0ae5e9a2d) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
kadinsayani
force-pushed
the
file-push-pull-completions
branch
from
d52403e to
7f3886c
Compare
4 tasks
simondeziel
approved these changes
Jan 8, 2025
tomponline
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves completions for
lxc fileand fixes an issue withlxc profile copycompletions.Summary of changes:
toCompleteparameter.cmpFilesfor improvedlxc file push|pullcompletions.lxc profile copycompletions by making use of thecmpProfilesfunction.Cherry-picks from lxc/incus#1445, lxc/incus#1453 and lxc/incus#1454.