test: drop FilesystemMockingTestCase in netconfig #6290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
blackboxsw
reviewed
Jul 8, 2025
blackboxsw
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Two non-blocking comments, and +1 on this PR. Thanks a lot @aciba90
aciba90
force-pushed
the
drop-FilesystemMockingTestCase-netconfig
branch
from
c3944fc to
692aa89
Compare
|
Thanks, for the reviews and good suggestions, I have applied them. Please re-review. |
blackboxsw
force-pushed
the
drop-FilesystemMockingTestCase-netconfig
branch
from
692aa89 to
8ee596d
Compare
blackboxsw
pushed a commit
that referenced
this pull request
Jul 16, 2025
Move it to tests.unitests.helpers, make it public and prepare for use in other tests cases.
Move it to tests.unitests.helpers, make it public and prepare for use in other tests cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
#5760
Test Steps
Merge type