Skip to content

feat(azure): Domain deployment for AKS single region docs #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 94 commits into
base: main
Choose a base branch
from

Conversation

bkenez
Copy link
Member

@bkenez bkenez commented Jun 2, 2025

Description

Iterating on the base domainless version of AKS single region docs, this PR adds steps for installing it with a domain for parity with the EKS guide.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and are in the /docs directory (version 8.8).
  • My changes are for an already released minor and are in a /versioned_docs directory.

bkenez and others added 30 commits May 1, 2025 18:23
@github-actions github-actions bot temporarily deployed to camunda-docs June 18, 2025 13:03 Destroyed
@bkenez
Copy link
Member Author

bkenez commented Jun 18, 2025

Addressed your comments! Thanks for being thorough.

Root cause for the files drifting seems to have been pre-commit; restoring from main and committing with --no-verify fixed the drift.

@bkenez bkenez requested a review from leiicamundi June 18, 2025 13:31
@github-actions github-actions bot temporarily deployed to camunda-docs June 18, 2025 13:36 Destroyed
Copy link
Contributor

@leiicamundi leiicamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally tested all!

Domain instructions looks good, I've just noticed 2 minor adjustments.

Don't hesitate to ping me when the other conversations are resolved so I can review it again and we should be good to merge then.

Thank you again for this AKS integration ;)

@github-actions github-actions bot temporarily deployed to camunda-docs June 20, 2025 10:33 Destroyed
leiicamundi
leiicamundi previously approved these changes Jun 23, 2025
Copy link
Contributor

@leiicamundi leiicamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a final review — LGTM!
Thank you for all your work and patience. ;)

@bkenez
Copy link
Member Author

bkenez commented Jun 24, 2025

Thank you! Much appreciated 👍
In that case:

@bkenez bkenez requested a review from a team June 24, 2025 07:36
@camunda-docs-pr-automation camunda-docs-pr-automation bot moved this to 👀 In Review in Documentation Team Jun 24, 2025
@github-actions github-actions bot temporarily deployed to camunda-docs June 24, 2025 07:45 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs June 24, 2025 15:36 Destroyed
Copy link
Contributor

The preview environment relating to the commit 62e042f has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-5912/

@leiicamundi
Copy link
Contributor

@bkenez last feedback regarding the backport:

@bkenez
Copy link
Member Author

bkenez commented Jun 24, 2025

Snippets show up after the merge, and sidebar links were corrected.
Not sure why it might render differently, the only diff between the files is the branch the snippets point to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Stand up a temporary docs site with this PR low prio There is no urgency with this change. target:8.8 Issues included in the 8.8 release
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants