-
Notifications
You must be signed in to change notification settings - Fork 207
feat(azure): Domain deployment for AKS single region docs #5912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…dd-azure-aks-single-region-docs
Co-authored-by: Lars Lange <[email protected]>
…/camunda/camunda-docs into add-azure-aks-single-region-docs
Co-authored-by: Lars Lange <[email protected]>
…/camunda/camunda-docs into add-azure-aks-single-region-docs
Co-authored-by: Lars Lange <[email protected]>
Addressed your comments! Thanks for being thorough. Root cause for the files drifting seems to have been pre-commit; restoring from main and committing with --no-verify fixed the drift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally tested all!
Domain instructions looks good, I've just noticed 2 minor adjustments.
Don't hesitate to ping me when the other conversations are resolved so I can review it again and we should be good to merge then.
Thank you again for this AKS integration ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a final review — LGTM!
Thank you for all your work and patience. ;)
Thank you! Much appreciated 👍
|
…hub.com/camunda/camunda-docs into add-azure-aks-single-region-docs-domain
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/terraform-setup.md
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/terraform-setup.md
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/aks-helm.md
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/aks-helm.md
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/aks-helm.md
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/azure/microsoft-aks/aks-helm.md
Show resolved
Hide resolved
…hub.com/camunda/camunda-docs into add-azure-aks-single-region-docs-domain
The preview environment relating to the commit 62e042f has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-5912/ |
@bkenez last feedback regarding the backport:
|
Snippets show up after the merge, and sidebar links were corrected. |
Description
Iterating on the base domainless version of AKS single region docs, this PR adds steps for installing it with a domain for parity with the EKS guide.
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.