-
Notifications
You must be signed in to change notification settings - Fork 207
fix: add diagnistics script to sidebars #5741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Confirmed that all scripts are showing now up in the sidebar of the versions! |
@@ -1083,7 +1083,8 @@ | |||
"self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-app-example" | |||
] | |||
}, | |||
"self-managed/platform-deployment/troubleshooting" | |||
"self-managed/platform-deployment/troubleshooting", | |||
"self-managed/platform-deployment/diagnostics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hisImminence Does this page exist in 8.4? I'm not sure this should be in the 8.4 sidebar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you are right - moved it under the operational-guide
! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hisImminence I saw the problem was in the file path, so I've adjusted it to point to the platform-deployment path, and it now appears in the sidebar under troubleshooting as I think you wanted? We don't need to move it for 8.4 as that would need redirects etc - I think this is the sidebar behaviour you were after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the sidebar fix is correct, happy to approve! 🚀
One thing @hisImminence is that I notice the changes to the 8.8 file following review of #5683 were not propagated to 8.4 -8.7 - we should create a new docs issue to fix this, unless you want to handle it in this PR? Would you like me to take this?
🧹 Preview environment for this PR has been torn down. |
@hisImminence TW review comments backport work for 8.4-8.7 covered in #5753 |
Description
This fix adds the diagnostic script to the sidebars of version 8.4-8.7 (it was missed in the prior PR https://github.com/camunda/camunda-docs/pull/5683/files and only added to the sidebar of 8.8)
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.