-
Notifications
You must be signed in to change notification settings - Fork 202
Connector casing (wave 1 - connectors) #5702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.7/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
FYI @YanaSegal 👍 |
docs/components/connectors/custom-built-connectors/connector-template-generator.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a spot check here based on the changes, and this looks great.
I found one unrelated typo, which you can choose to address in this PR or separately (I'm assuming it's across multiple versions 🥲 ).
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
versioned_docs/version-8.7/components/connectors/out-of-the-box-connectors/kafka.md
Show resolved
Hide resolved
Thanks @akeller - please can I get another approval - I fixed the typo across versions in this PR, as I had to fix a merge conflict caused by an update to a connector doc - thank you! 🙏 |
Description
This PR begins tackling the monumental task of changing Connector > connector casing throughout the docs.
See https://github.com/camunda/documentation-team/issues/429.
For example, Email Connector > Email connector.
Due to the size of this change, this PR only focuses on:
Follow-up PRs will tackle casing outside of the Connectors section - there are many thousands of instances, all of which probably need some manual checking.
Gotchas
Changing this word/case has to be done carefully, here is the method I used
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.