Skip to content

feat: allow for non-self assignment #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

jonathanlukas
Copy link
Contributor

@jonathanlukas jonathanlukas commented Apr 28, 2025

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and are in the /docs directory (version 8.8).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@jonathanlukas jonathanlukas requested review from marcosgvieira and a team April 28, 2025 11:21
@jonathanlukas jonathanlukas self-assigned this Apr 28, 2025
@akeller akeller moved this to 👀 In Review in Documentation Team Apr 28, 2025
Copy link
Contributor

github-actions bot commented Apr 28, 2025

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

marcosgvieira
marcosgvieira previously approved these changes Apr 28, 2025
Copy link
Contributor

@marcosgvieira marcosgvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathanlukas, LGTM

@jonathanlukas jonathanlukas enabled auto-merge (squash) April 28, 2025 12:15
@jonathanlukas jonathanlukas added the low prio There is no urgency with this change. label Apr 28, 2025
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but I did find myself wondering what deployment options I could use this for. My guess is this wouldn't work for C8Run, but should work for local K8 and Docker Compose.

@jonathanlukas
Copy link
Contributor Author

I guess this will also work with C8Run. Not tested, will be used with docker-compose

@jonathanlukas jonathanlukas merged commit 929e6df into main Apr 28, 2025
9 checks passed
@jonathanlukas jonathanlukas deleted the tasklist-allow-non-self-assignment branch April 28, 2025 18:49
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Documentation Team Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low prio There is no urgency with this change.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants