Skip to content

docs: fix a couple preview deploy incorrections #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

pepopowitz
Copy link
Contributor

Description

Updates the preview-env-deploy.yaml workflow to correct a couple small issues:

  1. The build doesn't take nearly as long as it used to.
  2. The preview link was taking you to a URL that contains two home pages stacked on top of each other 😱. I have no idea why this was happening. But everything is fine if we remove the index.html from the URL, which is how the real docs site would be navigated anyway. (We were originally including the index.html due to the preview environment infrastructure requiring it, but it doesn't seem to be required anymore.)

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and are in the /docs directory (version 8.8).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@pepopowitz pepopowitz added kind/bug Issues related with bugs in the documentation dx Documentation infrastructure typically handled by the Camunda DX team labels Apr 18, 2025
@pepopowitz pepopowitz self-assigned this Apr 18, 2025
@akeller akeller moved this to 👀 In Review in Documentation Team Apr 18, 2025
@pepopowitz pepopowitz merged commit 8f837bd into main Apr 21, 2025
14 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/preview-deploy-corrections branch April 21, 2025 14:38
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Documentation Team Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants