Skip to content

r1.4 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2024
Merged

r1.4 #167

merged 4 commits into from
Dec 11, 2024

Conversation

fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction
  • subproject management
  • tests

What this PR does / why we need it:

Preparation for public release r1.4. It includes updates and fixes for test plan to be fully compliant with version v0.2.1 and a correction in the API Readiness checklist.

Which issue(s) this PR fixes:

Fixes #159

GillesInnov35
GillesInnov35 previously approved these changes Nov 8, 2024
Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Fernando

GillesInnov35
GillesInnov35 previously approved these changes Nov 12, 2024
Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fernandopradocabrillo fernandopradocabrillo requested a review from a team November 12, 2024 08:24
@fernandopradocabrillo
Copy link
Collaborator Author

Hi @camaraproject/release-management_maintainers please take a quick look to check that everything is correct.
@ToshiWakayama-KDDI if you have time please also take a look 😄
Thanks!

Copy link
Collaborator

@ToshiWakayama-KDDI ToshiWakayama-KDDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fernandopradocabrillo .

@fernandopradocabrillo
Copy link
Collaborator Author

Hi @hdamker, @camaraproject/release-management_maintainers is it okey if we merge this PR? Thanks!

@hdamker
Copy link
Contributor

hdamker commented Nov 19, 2024

Sorry, I was ooo last week. Have created now the review issue in RM.

hdamker
hdamker previously approved these changes Dec 10, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks from release management perspective.

One suggestion for clarity, which you can take or leave.

Co-authored-by: Herbert Damker <[email protected]>
@fernandopradocabrillo
Copy link
Collaborator Author

Looks from release management perspective.

One suggestion for clarity, which you can take or leave.

I'll take it, I think it provides detail

Copy link
Collaborator

@ToshiWakayama-KDDI ToshiWakayama-KDDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fernandopradocabrillo fernandopradocabrillo merged commit 73a7058 into camaraproject:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad URL for User stories and Basic API test cases link in kyc-match-API-Readiness-Checklist.md and in kyc-fill-in-API-Readiness-Checklist.md
4 participants