Skip to content

Alpha release r3.1 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Alpha release r3.1 #292

merged 2 commits into from
May 16, 2025

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Apr 30, 2025

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is the release PR for the pre-release r3.1 (first alpha release for Fall25) containing version v0.4.0-alpha.1 of ICM

Which issue(s) this PR fixes:

It is related to #275

Special notes for reviewers:

This PR includes all the changes in the ICM scope of the Fall25 meta-release that have been merged so far. However, there are still open discussions that will need to be included when consensus is reached.

Changelog input

 r3.1 containing version v0.4.0-alpha.1 of ICM

Additional documentation

https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/36241429/Meta-release+Fall25
https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14551399/Meta-release+Process#Commonalities-and-ICM

Copy link

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Release Management: the release PR looks fine except for some tweeks that need to be fixed.

for content I will review separately.

CHANGELOG.md Outdated

## Release Notes

This public release contains the definition and documentation of:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "public" to "alpha"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this should not name a public release. But shouldn't it be "pre-release"? (as there is no such thing as an "alpha" release)

My suggestion:

Suggested change
This public release contains the definition and documentation of:
This pre-release contains the definition and documentation of:

"alpha" is correctly used in line 30.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, guys. My mistake. It was a copy & paste problem. I forgot to update that, which should be the same as in release 2.1, for example.

This pre-release contains the definition and documentation of:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8218df4

README.md Outdated
@@ -16,7 +16,10 @@ Repository to describe, develop, document and test the Identity And Consent Mana

## Release Information

* `NEW`: The "Spring25" public release of the "Identity and Consent Management" guidelines and documentation for the CAMARA APIs is available under the tag [r2.3](https://github.com/camaraproject/IdentityAndConsentManagement/tree/r2.3). It contains the current [version](/VERSION.yaml) of the documents which are relevant for the [Spring25 meta-release](https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14560849/Meta-release+Spring25), including:
* `NEW`: The "Fall25" alpha release of the "Identity and Consent Management" guidelines and documentation for the CAMARA APIs is available under the tag [r3.1](https://github.com/camaraproject/IdentityAndConsentManagement/tree/r3.1). It contains the alpha [version](/VERSION.yaml) of the documents which are relevant for the [Fall25 meta-release](https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/36241429/Meta-release+Fall25), including:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reference to the VERSION file needs to be a full link pointing to the release, not a local link.
The same should be applied to the paragraph below as it will now point to the wrong VERSION for that previous release.
Alternatively, you could put the local link outside the release dependent sections, and only point to the latest version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as above, it is a "pre-release" with the alpha version, but not an "alpha release".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8218df4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a reference to "main" on line 290 pointing to the Commonalities WG.
the GitHub link should be: https://github.com/camaraproject/Commonalities
the link seems to be wrong - if the intention was to point to the Wiki "Commonalities WG, use this link:
https://lf-camaraproject.atlassian.net/wiki/x/_QPe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is actually correct, pointing into the archived workinggroup repository which existed at that time. Even the copied version of the document can still be found there (but moved into an "archive" folder): https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/archive/CAMARA-AuthN-AuthZ-Concept.md

I wouldn't touch the history within the CHANGELOG.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @hdamker

Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpengar jpengar requested review from tanjadegroot and hdamker May 15, 2025 07:00
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comments are addressed the PR looks good from release management perspective and should be merged as discussed within yesterday's TSC meeting.

@hdamker hdamker dismissed tanjadegroot’s stale review May 16, 2025 11:08

Comments are addressed

@jpengar jpengar merged commit 6951af4 into main May 16, 2025
1 check passed
@jpengar jpengar deleted the jpengar/icm-release-r3.1 branch May 28, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants