Skip to content

Profile screen accessibility snapshot #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 19, 2023
Merged

Conversation

DimitarNestorov
Copy link
Collaborator

@DimitarNestorov DimitarNestorov commented Apr 19, 2023

@github-actions
Copy link

Xcode failed when running tests.

Check the workflow logs and artifacts.

@DimitarNestorov DimitarNestorov force-pushed the accessibility-snapshot branch from c440250 to 1ae2645 Compare April 19, 2023 13:08
@callstack-internal callstack-internal deleted a comment from github-actions bot Apr 19, 2023
@DimitarNestorov DimitarNestorov force-pushed the accessibility-snapshot branch from 1ae2645 to 6c38235 Compare April 19, 2023 13:42
@DimitarNestorov DimitarNestorov marked this pull request as ready for review April 19, 2023 13:43
@DimitarNestorov DimitarNestorov merged commit afa33e0 into main Apr 19, 2023
@DimitarNestorov DimitarNestorov deleted the accessibility-snapshot branch April 19, 2023 13:44
@DimitarNestorov
Copy link
Collaborator Author

Forgot to check if the app actually builds. Turned out I was linking the app target to the testing frameworks. Fixed in c994a7d.

@DimitarNestorov
Copy link
Collaborator Author

Turns out I didn't need to link SnapshotTesting. When adding AccessibilitySnapshot I just had to select the correct target.
Fixed in #6
image

import SnapshotTesting
import XCTest

class AccessibilitySnapshotTests : XCTestCase {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class AccessibilitySnapshotTests : XCTestCase {
class AccessibilitySnapshotTests: XCTestCase {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant