Skip to content

PHP 8.1 - Return type issues #840

Open
@jsandfordhughes

Description

@jsandfordhughes

I am using this package with PHP 8.1 and while everything works correctly there are a few warnings that popup for interface compatibility.

The ones I have seen are the following:

Return type of XeroPHP\Remote\Model::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed

Return type of XeroPHP\Remote\Model::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool

Return type of XeroPHP\Remote\Model::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed

Return type of XeroPHP\Remote\Model::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void

Return type of XeroPHP\Remote\Model::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void

Happy to do a PR for these if nothing is in the pipeline?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions