Skip to content

Recommended changes resulting from automated audit #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
Jericho opened this issue Jun 5, 2018 · 1 comment · Fixed by #13
Closed
1 of 2 tasks

Recommended changes resulting from automated audit #9

Jericho opened this issue Jun 5, 2018 · 1 comment · Fixed by #13
Labels
Breaking change
Milestone
0.3.0

Comments

@Jericho
Copy link
Member

Jericho commented Jun 5, 2018 •
edited by gep13
Loading

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.17.0. Please upgrade to 0.33.0
  • The nuget package for your addin should use the cake-contrib icon. Specifically, your addin's .csproj should have a line like this: <PackageIconUrl>https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png</PackageIconUrl>.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.
@Jericho
Copy link
Member Author

Jericho commented Apr 20, 2019

We performed a follow up automated audit of your Cake addin and found that some (or all) issues previously identified have not been resolved.

We strongly encourage you to make the modifications previously highlighted.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This comment was created by a tool: Cake.AddinDiscoverer version 3.12.1

@Jericho Jericho mentioned this issue Apr 30, 2019
Merged
@gep13 gep13 added this to the 0.3.0 milestone Sep 1, 2019
@gep13 gep13 mentioned this issue Sep 1, 2019
Closed
@gep13 gep13 closed this as completed in #13 Sep 1, 2019
@gep13 gep13 reopened this Sep 1, 2019
gep13 added a commit that referenced this issue Sep 1, 2019
@gep13
(GH-9) Update iconUrl to recommendation
f618775
gep13 added a commit that referenced this issue Sep 1, 2019
@gep13
(GH-9) Fix NuGet lib folder
104a6e8
gep13 added a commit that referenced this issue Sep 1, 2019
@gep13
(GH-9) Update to Cake 0.33.0
ac7ac0d
@gep13 gep13 closed this as completed Sep 1, 2019
gep13 added a commit that referenced this issue Sep 1, 2019
@gep13
Merge branch 'release/0.3.0'
fbc346b 
* release/0.3.0: (23 commits)
  (GH-9) Update to Cake 0.33.0
  (GH-14) Add .DS_Store to .gitignore file
  (GH-9) Fix NuGet lib folder
  (GH-14) Add standard AppVeyor config file
  (GH-14) Add EditorConfig file
  (GH-14) Add GitHub Template files
  (GH-14) Update NuGet metadata
  (GH-14) Always run GitVersion
  (GH-9) Update iconUrl to recommendation
  (GH-14) Pin to 1.0.0 of Cake.Recipe
  (GH-14) Switch to recipe.cake file
  (GH-14) Update to latest Cake bootstrappers
  (build) Changed Boostrappers
  (GH-4) Switch to Cake-Contrib Logo
  Updated Cake.Webpack to Cake.Core 0.23.0
  Pin Cake Version: 0.22.2
  Pin Cake.Core at 0.22.2
  Revert "Issue #6 - Attempt to fix AppVeyor build"
  Issue #6 - Attempt to fix AppVeyor build
  Issue #6 - Update projects to .NET 4.6.1
  ...
cake-contrib-bot pushed a commit that referenced this issue Sep 1, 2019
@gep13
AppVeyor Publish: fbc346b
8af6669 
Merge branch 'release/0.3.0'

* release/0.3.0: (23 commits)
  (GH-9) Update to Cake 0.33.0
  (GH-14) Add .DS_Store to .gitignore file
  (GH-9) Fix NuGet lib folder
  (GH-14) Add standard AppVeyor config file
  (GH-14) Add EditorConfig file
  (GH-14) Add GitHub Template files
  (GH-14) Update NuGet metadata
  (GH-14) Always run GitVersion
  (GH-9) Update iconUrl to recommendation
  (GH-14) Pin to 1.0.0 of Cake.Recipe
  (GH-14) Switch to recipe.cake file
  (GH-14) Update to latest Cake bootstrappers
  (build) Changed Boostrappers
  (GH-4) Switch to Cake-Contrib Logo
  Updated Cake.Webpack to Cake.Core 0.23.0
  Pin Cake Version: 0.22.2
  Pin Cake.Core at 0.22.2
  Revert "Issue #6 - Attempt to fix AppVeyor build"
  Issue #6 - Attempt to fix AppVeyor build
  Issue #6 - Update projects to .NET 4.6.1
  ...
cake-contrib-bot pushed a commit that referenced this issue Sep 1, 2019
@gep13
AppVeyor Publish: fbc346b
bea093a 
Merge branch 'release/0.3.0'

* release/0.3.0: (23 commits)
  (GH-9) Update to Cake 0.33.0
  (GH-14) Add .DS_Store to .gitignore file
  (GH-9) Fix NuGet lib folder
  (GH-14) Add standard AppVeyor config file
  (GH-14) Add EditorConfig file
  (GH-14) Add GitHub Template files
  (GH-14) Update NuGet metadata
  (GH-14) Always run GitVersion
  (GH-9) Update iconUrl to recommendation
  (GH-14) Pin to 1.0.0 of Cake.Recipe
  (GH-14) Switch to recipe.cake file
  (GH-14) Update to latest Cake bootstrappers
  (build) Changed Boostrappers
  (GH-4) Switch to Cake-Contrib Logo
  Updated Cake.Webpack to Cake.Core 0.23.0
  Pin Cake Version: 0.22.2
  Pin Cake.Core at 0.22.2
  Revert "Issue #6 - Attempt to fix AppVeyor build"
  Issue #6 - Attempt to fix AppVeyor build
  Issue #6 - Update projects to .NET 4.6.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Fix issues identified by automated audit
2 participants
@Jericho @gep13