Custom Realm support on sync #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @raullermen , thanks for your contributions. And I've appended some changes:
Take a look if you have time. And this pr is gonna be merged. Thanks! |
|
Hi @caiyue1993 |
Rifmovnik
added a commit
to Rifmovnik/IceCream
that referenced
this pull request
Apr 13, 2019
* commit 'afebc8a0883d9724a6adda263d5110eb833634d0': (43 commits) Fix typo bump version Removed cream.swift reference in xcodeproj bump version number to 1.8.0 add 1.7.2 & 1.8.0 in CHANGELOG add support for the conversion of recordID to Int type primaryKey make parseFromRecord method static Custom Realm support on sync (caiyue1993#108) weak self to avoid potential retain cycle Allow SyncEngine to use custom CKContainers (besides default) use guard statement instead set default `shouldOverwrite` value to true Update CreamAsset.swift Add support for overwrite prevention; object id init Make guard statement one line Revert the changes of CreamAsset Mark save func as private and use FileManager Use break and continue correctly Update README.md Resolve `cannot use an empty list to initialize a new field` ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @caiyue1993,
I had crashing problems when tried to use my custom Realm (schema versioning issues), so I needed to pass my Realm reference to SyncEngine.
I believe this problem is related to #86 and may can resolve issue #17.
Second, SyncEngine was ignoring my In64 list, so I made a slight modification on the Int list conversion.
Check if these modifications fits your design vision.
And thanks for the great work on this project!