ci: Fix build caching on Windows #4811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting tired of Windows being slow as molasses in our CI jobs, so I went to look at our trusty source of github actions + golang information, and found a somewhat recent commit that actually fixed it. See mvdan/github-actions-golang@4b75472 I'll do a 2nd empty commit to re-trigger CI shortly to confirm that it actually fixes it.
|
Still seems really slow. Bah. Probably worth having anyways. |
|
You are asking Windows to be fast, Francis 😄 Is the extra complexity of this CI job worth the lack of improvement? (Thank you for trying this out! I'm not opposed to this, just want to discuss it first, since the expected results aren't apparent.) |
|
It's actually less complex in this case, cause we're not relying on pulling the path from env anymore, and just hardcoding them. I think we should merge anyways. It's still a correctness fix, I'm just disappointed it didn't help much is all. |
mholt
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting tired of Windows being slow as molasses in our CI jobs, so I went to look at our trusty source of github actions + golang information, and found a somewhat recent commit that actually fixed it. See mvdan/github-actions-golang@4b75472
I'll do a 2nd empty commit to re-trigger CI shortly to confirm that it actually fixes it.