Skip to content

Implementation of the independent feature from ADVbumpversion #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

andrivet
Copy link
Contributor

This is an implementation (back port) of the independent feature from ADVbumpversion, as discussed in #121. This feature implements #81. If this PR can be merged, I will close ADVbumpversion fork and redirect people to bump2version.

@florisla florisla added this to the Next release milestone Oct 15, 2021
@florisla
Copy link
Collaborator

Thanks, would be great to 'merge user bases' with ADVbumpversion!

@florisla florisla self-requested a review October 15, 2021 07:08
@andrivet
Copy link
Contributor Author

As soon as the new version of bump2version is released, I will put the ADVbumpversion GitHub project in Archived state, and change the README to explain how to migrate to bump2version (since the syntax is a little bit different when using the same file in different rules). I will also probably shutdown the project on PyPi or make it clear that it is deprecated.

Also, if you need help for bump2version, let me know.

Copy link
Collaborator

@florisla florisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, and it's great to consolidate projects!

Could you rebase on master?

@florisla
Copy link
Collaborator

Also, if you need help for bump2version, let me know.

Surely, the pull request backlog could use some love.

Supporting Python 3.9 and 3.10 would be great!

@andrivet
Copy link
Contributor Author

andrivet commented Feb 26, 2022

Could you rebase on master?

But it is already the case.

@florisla
Copy link
Collaborator

florisla commented Mar 1, 2022

Master branch has been updated in the meantime...

"This branch is 3 commits ahead, 4 commits behind c4urself:master. "

@florisla florisla merged commit bc95374 into c4urself:master Mar 2, 2022
@andrivet
Copy link
Contributor Author

Any plan to make a new release and update the Pypi version? I am waiting for this in order to kill my fork and redirect people to this project.

@ekohl
Copy link
Collaborator

ekohl commented Apr 4, 2022

I still have permissions on this project, but I lack time. If a PR is prepared to do the release I'd be happy to merge it and push it to PyPI.

On a related note, I think we should add more maintainers. @florisla thoughts on adding @andrivet as a maintainer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants