Analyser: force parentheses for ambiguous operator combinations #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chqrlie
changed the title
|
Nice.. I dont understand the C_prec is the binary-operator analyser. The c2 only i can understand. |
bvdberg
reviewed
Jun 22, 2025
parser/c2_parser_expr.c2
Outdated
| @@ -606,7 +589,8 @@ fn Expr* Parser.parseSizeof(Parser* p) { | |||
| while (p.tok.kind != Kind.LSquare) p.consumeToken(); | |||
| p.error("arrays or subscripts expressions are not allowed inside a sizeof expression"); | |||
| } | |||
| TypeRefHolder ref.init(); | |||
| TypeRefHolder ref; | |||
| ref.init(); | |||
There was a problem hiding this comment.
why did you change this back to 2 lines?
There was a problem hiding this comment.
unintended, maybe a git rebase glitch, fixed.
The C precedence table is used as a reference to check if a combination of operators is ambiguous:
|
chqrlie
force-pushed
the
paren
branch
2 times, most recently
from
a074feb to
eda632f
Compare
* flag use of combined operators with unintuitive relative precedence as constraint violations (analyser errors) * fix code like `if (buf.st_mode & S_IFMT == S_IFREG)` that now requires parentheses: `if ((buf.st_mode & S_IFMT) == S_IFREG)` * update tests
|
merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (buf.st_mode & S_IFMT == S_IFREG)that now requires parentheses:if ((buf.st_mode & S_IFMT) == S_IFREG)