compiler: cosmetic changes #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chqrlie
force-pushed
the
cosmetics
branch
2 times, most recently
from
1828640 to
43971d5
Compare
|
Why did you add the startsWith() function? It is not used at all. We'r not building libc (yet) ;) |
chqrlie
force-pushed
the
cosmetics
branch
3 times, most recently
from
f145e18 to
1cd8528
Compare
|
I implemented tools/tester/test_db.c2 has a number of tests for prefixes that have hard coded lengths that would benefit from a simpler API, possibly returning the pointer to the next character or returning it via a pointer. Note that there is a similar function We can discuss a good API for this. I have removed the current implementation of |
chqrlie
force-pushed
the
cosmetics
branch
3 times, most recently
from
bab9ca7 to
1501c0e
Compare
* fix `Writer.getError()` messages * import string as local for consistency * more cosmetic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writer.getError()messagesstartsWith(const char* text, const char* prefix, const char** pp)