Skip to content

Fix/dropdown: Flexbox 수정사항 반영 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

prayinforrain
Copy link
Contributor

@prayinforrain prayinforrain commented Feb 28, 2023

🤠 개요

브랜치를 파서 Dropdown을 구현하는 사이에 Flexbox의 props 이름이 변경되어 오류가 나는 문제를 수정했어요.
그리고 그 김에 사용하지 않는 import도 제거했어요.
아래 이슈에 아주 약간 더 자세한 설명이 있어요.

💫 설명

  • Flexbox props direction -> flexDirection 변경
  • unused import 제거

📷 스크린샷 (Optional)

😱

@prayinforrain prayinforrain added the 🛠 fix 버그 수정 label Feb 28, 2023
@prayinforrain prayinforrain self-assigned this Feb 28, 2023
Copy link
Member

@iyu88 iyu88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prayinforrain prayinforrain merged commit c3e703d into main Feb 28, 2023
@prayinforrain prayinforrain deleted the fix/dropdown branch February 28, 2023 15:51
iyu88 pushed a commit that referenced this pull request Mar 6, 2023
* fix: flexbox props 수정 반영

* fix: 불필요한 import 삭제
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 fix 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants