feat: ability to specify security group name

[BScott-c]

When old database instances were NOT created with this terraform module and we migrate it to use this terraform module the security group name is not matching causing further down time in the migration that can be avoided by allowing us to specify the security group name.

[github-actions]

Terraform Plan for ./examples/ci-1_0:

will create 10 resources:

• aws_cloudwatch_log_group - db_logs
• aws_cloudwatch_log_group - db_logs
• aws_cloudwatch_log_group - db_logs
• aws_db_instance - database
• aws_db_parameter_group - parameter_group
• aws_security_group - db_security_group
• aws_ssm_parameter - master_password
• aws_ssm_parameter - master_username
• random_password - default
• random_string - default

see details

[github-actions]

Terraform Plan for ./examples/ci-1_2:

will create 10 resources:

• aws_cloudwatch_log_group - db_logs
• aws_cloudwatch_log_group - db_logs
• aws_cloudwatch_log_group - db_logs
• aws_db_instance - database
• aws_db_parameter_group - parameter_group
• aws_security_group - db_security_group
• aws_ssm_parameter - master_password
• aws_ssm_parameter - master_username
• random_password - default
• random_string - default

see details

[BScott-c]

Question : will it update the version and everything by itself when it deploys or do I need to do that?

[stuft2]

I think we have to change all the version numbers in the documentation before we merge

[yoshutch]

Yeah, we'll need to bump the terraform version in the README.md to the next minor version since you're just adding a variable, so not breaking change. Then add this new variable to the inputs table. Then I think you're good

[yoshutch]

LGTM as long as you see a valid plan using this. You could even test it out on your other repo by setting the "version" to this branch name like source = "github.com/byu-oit/terraform-aws-rds?ref=feat/sgName"

[BScott-c]

Couldn't test with the naming of the branch. Use #38 instead