Skip to content

Add framing for TcpSocket #1262

Open
Open
@segeljakt

Description

@segeljakt

Hi, I would like to add framing to WASI TCP streams. Tokio provides this functionality with tokio_util::codec::{FramedRead, FramedWrite}, which relies on tokio::io::{AsyncRead, AsyncWrite}. Would it be possible to implement these traits for wit_bindgen::async_support::{StreamReader, StreamWriter} or TcpSocket?

I think it would look like this:

impl tokio::io::AsyncRead for wit_bindgen::async_support::StreamWriter<u8> {
    fn poll_read(
        self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
        buf: &mut tokio::io::ReadBuf<'_>,
    ) -> std::task::Poll<std::io::Result<()>> {
        ...
    }
}

impl tokio::io::AsyncWrite for wit_bindgen::async_support::StreamWriter<u8> {
    fn poll_write(
        self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
        buf: &[u8],
    ) -> std::task::Poll<Result<usize, std::io::Error>> {
        ...
    }

    fn poll_flush(
        self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
    ) -> std::task::Poll<Result<(), std::io::Error>> {
        ...
    }

    fn poll_shutdown(
        self: std::pin::Pin<&mut Self>,
        cx: &mut std::task::Context<'_>,
    ) -> std::task::Poll<Result<(), std::io::Error>> {
        ...
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions