Skip to content

add Component Model async ABI tests #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025
Merged

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Jun 25, 2025

This pulls in the tests from the wasip3-prototyping repo, minus the ones requiring WASIp3 support in wasmtime-wasi[-http], which will be PR'd separately.

Note that this builds on #11127.

@dicej dicej requested review from a team as code owners June 25, 2025 22:10
@dicej dicej requested review from alexcrichton and removed request for a team June 25, 2025 22:10
@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Jun 26, 2025
@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Jul 2, 2025
Copy link

github-actions bot commented Jul 2, 2025

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton force-pushed the cm-async-tests branch 4 times, most recently from d1cf3be to 8b2baa7 Compare July 2, 2025 21:16
@dicej dicej force-pushed the cm-async-tests branch 3 times, most recently from 7c41e9f to eda3c8f Compare July 8, 2025 17:50
This pulls in the tests from the `wasip3-prototyping` repo, minus the ones
requiring WASIp3 support in `wasmtime-wasi[-http]`, which will be PR'd
separately.
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

In order to convince `cargo vet` that we only needed these deps to be
`safe-to-run` (not necessarily `safe-to-deploy`, since it's test code), I've
moved the `wasm-compose` dep to the `dev-dependencies` section of the
`Cargo.toml` file, which required rearranging some code.

I've exempted `wasm-compose` since it's a BA project, and also exempted all but
one of the remaining new deps since they each get well over 10,000 downloads per
day from crates.io.  I've audited and certified the remaining dep, `im-rc`,
which came in a bit shy of the 10,000-per-day mark.

Signed-off-by: Joel Dice <[email protected]>
@alexcrichton alexcrichton enabled auto-merge July 11, 2025 23:14
@alexcrichton alexcrichton disabled auto-merge July 11, 2025 23:14
@dicej dicej enabled auto-merge July 11, 2025 23:18
@dicej dicej added this pull request to the merge queue Jul 11, 2025
Merged via the queue into bytecodealliance:main with commit 804060c Jul 11, 2025
42 checks passed
@dicej dicej deleted the cm-async-tests branch July 11, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issues related to our fuzzing infrastructure wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants