Skip to content

Add support sqrtps, sqrtpd, sqrtss, sqrtsd #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support sqrtps, sqrtpd, sqrtss, sqrtsd #10768

wants to merge 1 commit into from

Conversation

jlb6740
Copy link
Contributor

@jlb6740 jlb6740 commented May 12, 2025

No description provided.

@jlb6740 jlb6740 requested a review from a team as a code owner May 12, 2025 01:25
@jlb6740 jlb6740 requested review from fitzgen and removed request for a team May 12, 2025 01:25
@jlb6740 jlb6740 marked this pull request as draft May 12, 2025 01:25
@jlb6740 jlb6740 force-pushed the add-sqrt-instructions branch from ed92527 to 9b654b0 Compare May 12, 2025 01:34
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels May 12, 2025
fitzgen
fitzgen approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @abrown did you want to give a look at this, since you're much more familiar with the new x64 assembler?

@abrown
Copy link
Contributor

abrown commented May 13, 2025

Yes, I'll take a look; I think there are a few things left to plumb through and some CI issues to fix so @jlb6740 was keeping this as a draft for now.

@abrown abrown self-requested a review May 13, 2025 18:13
@abrown abrown self-assigned this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@abrown abrown Awaiting requested review from abrown

Assignees

@abrown abrown

Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlb6740 @abrown @fitzgen