Skip to content

[s390x] Use VCodeConstant literal pool #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

uweigand
Copy link
Member

@uweigand uweigand commented May 9, 2025

This switches s390x to use the common-code VCodeConstant literal pool instead of constants inlined into the instruction stream.

This switches s390x to use the common-code VCodeConstant
literal pool instead of constants inlined into the instruction
stream.
@uweigand uweigand requested a review from a team as a code owner May 9, 2025 16:49
@uweigand uweigand requested review from cfallin and removed request for a team May 9, 2025 16:49
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. isle Related to the ISLE domain-specific language labels May 9, 2025
Copy link

github-actions bot commented May 9, 2025

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@cfallin cfallin added this pull request to the merge queue May 13, 2025
Merged via the queue into bytecodealliance:main with commit 55e56c1 May 13, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants