asm: improve DSL's understanding of prefixes #10475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Cranelift's x64 backend only understood a subset of the available prefixes that can be encoded and the documentation for these was quite sparse. This change upgrades the assembler to understand all kinds of prefixes, even those as yet unused, and drastically increases the amount of documentation around these prefixes. This, along with some new `Group`-based typing, should prevent accidental misuse but also increase confidence that this implementation is correctly covering the possible cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Cranelift's x64 backend only understood a subset of the available prefixes that can be encoded and the documentation for these was quite sparse. This change upgrades the assembler to understand all kinds of prefixes, even those as yet unused, and drastically increases the amount of documentation around these prefixes. This, along with some new
Group-based typing, should prevent accidental misuse but also increase confidence that this implementation is correctly covering the possible cases.