-
Notifications
You must be signed in to change notification settings - Fork 270
rumqttc: TLS Key encoding fix #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested with
|
As discussed in #751 I have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looks like Key
is still there in lib.rs
( that is why CI is failing ), please fix it as well : )
PS: This is a breaking change, so can we please update the PR description to clarify it?
Not sure why that test failed, seems unrelated? |
Yup, it keeps failing randomly 😜 |
Thank you for the PR! |
Type of change
Breaking Change
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.Description
This PR lets users of rumqttc use any of the Rustls supported key encodings [RSA (PKCS#1), PKCS#8, SEC1].
This issue addresses #751
I left the
Key
enum as is to prevent a breaking change, however it does no longer matter if the user chosesRSA
orECC
. For a cleaner API I think theKey
enum could be removed.