Skip to content

Read Unsubscribe Packet in v5 #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swanandx opened this issue May 29, 2023 · 5 comments
Closed

Read Unsubscribe Packet in v5 #625

swanandx opened this issue May 29, 2023 · 5 comments
Labels
broker Related to rumqttd good first issue Good for newcomers

Comments

@swanandx
Copy link
Member

Expected Behavior

Read and handle unsubscribe packet

Current Behavior

we panic if we get unsubscribe packet, as we reach unreachable!()

Failure Information (for bugs)

In v5 protocol, while reading packets, in match arms, we don't include unsubscribe packet. Thus it proceeds to _ => unreachable!().

Solution

Add Packet::Unsubscribe in match arm here and handle it properly.

@swanandx swanandx added good first issue Good for newcomers broker Related to rumqttd labels May 29, 2023
@coderr01
Copy link
Contributor

@swanandx I would like to contribute for the issue

@swanandx
Copy link
Member Author

@coderr01 Hey, thanks ( that was fast 😆 ), feel free to contribute!
Please open a PR once you are done with suggested solution 💯

@coderr01
Copy link
Contributor

@swanandx i am not able to push the changes. Can you provide the necessary permission ?

@swanandx
Copy link
Member Author

@swanandx i am not able to push the changes. Can you provide the necessary permission ?

Can you please fork the repo? That would nice

@coderr01
Copy link
Contributor

@swanandx please have a look on that #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broker Related to rumqttd good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants