-
Notifications
You must be signed in to change notification settings - Fork 191
sso_*: allow simultaneous use of Validators #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jusshersmith
merged 1 commit into
master
from
jusshersmith-OR-statement-allowed-email-settings
Oct 10, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,72 @@ | ||
| package options | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/buzzfeed/sso/internal/pkg/sessions" | ||
| ) | ||
|
|
||
| // NewEmailAddressValidator returns a function that checks whether a given email is valid based on a list | ||
| // of email addresses. The address "*" is a wild card that matches any non-empty email. | ||
| func NewEmailAddressValidator(emails []string) func(string) bool { | ||
| allowAll := false | ||
| var ( | ||
| _ Validator = EmailAddressValidator{} | ||
|
|
||
| // These error message should be formatted in such a way that is appropriate | ||
| // for display to the end user. | ||
| ErrEmailAddressDenied = errors.New("Unauthorized Email Address") | ||
| ) | ||
|
|
||
| type EmailAddressValidator struct { | ||
| AllowedEmails []string | ||
| } | ||
|
|
||
| // NewEmailAddressValidator takes in a list of email addresses and returns a Validator object. | ||
| // The validator can be used to validate that the session.Email: | ||
| // - is non-empty | ||
| // - matches one of the originally passed in email addresses | ||
| // (case insensitive) | ||
| // - if the originally passed in list of emails consists only of "*", then all emails | ||
| // are considered valid based on their domain. | ||
| // If valid, nil is returned in place of an error. | ||
| func NewEmailAddressValidator(allowedEmails []string) EmailAddressValidator { | ||
| var emailAddresses []string | ||
|
|
||
| for _, email := range emails { | ||
| if email == "*" { | ||
| allowAll = true | ||
| } | ||
| for _, email := range allowedEmails { | ||
| emailAddress := fmt.Sprintf("%s", strings.ToLower(email)) | ||
| emailAddresses = append(emailAddresses, emailAddress) | ||
| } | ||
|
|
||
| if allowAll { | ||
| return func(email string) bool { return email != "" } | ||
| return EmailAddressValidator{ | ||
| AllowedEmails: emailAddresses, | ||
| } | ||
| } | ||
|
|
||
| return func(email string) bool { | ||
| if email == "" { | ||
| return false | ||
| } | ||
| email = strings.ToLower(email) | ||
| for _, emailItem := range emailAddresses { | ||
| if email == emailItem { | ||
| return true | ||
| } | ||
| func (v EmailAddressValidator) Validate(session *sessions.SessionState) error { | ||
| if session.Email == "" { | ||
| return ErrInvalidEmailAddress | ||
| } | ||
|
|
||
| if len(v.AllowedEmails) == 0 { | ||
| return ErrEmailAddressDenied | ||
| } | ||
|
|
||
| if len(v.AllowedEmails) == 1 && v.AllowedEmails[0] == "*" { | ||
| return nil | ||
| } | ||
|
|
||
| err := v.validate(session) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (v EmailAddressValidator) validate(session *sessions.SessionState) error { | ||
| email := strings.ToLower(session.Email) | ||
| for _, emailItem := range v.AllowedEmails { | ||
| if email == emailItem { | ||
| return nil | ||
| } | ||
| return false | ||
| } | ||
| return ErrEmailAddressDenied | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.