Skip to content

Upload all pipelines present in the input #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

DrJosh9000
Copy link
Contributor

Description

Allow pipeline YAML containing more than one document. When using buildkite-agent pipeline upload with such an input, upload all of them.

Context

https://linear.app/buildkite/issue/PS-795

Changes

  • Update go-pipeline to v0.14.0
  • Change parseAndInterpolate to use pipeline.ParseAll and return an iterator
  • Change the action to put most of the work in a loop
  • Move dry-run output setup outside of the loop so that the output YAML will consist of multiple correctly-separated documents

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 force-pushed the ps-795-yaml-upload-issue branch from ad34a85 to fbcc552 Compare June 19, 2025 07:02
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks really clean with the iterator 👍🏻 🚀

@DrJosh9000 DrJosh9000 requested a review from a team June 19, 2025 07:10
@DrJosh9000 DrJosh9000 merged commit 6813364 into main Jun 19, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the ps-795-yaml-upload-issue branch June 19, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants