Skip to content

fix: Don't disconnect-after-idle when just given a job #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix: Don't disconnect-after-idle when just given a job #3312

merged 1 commit into from
May 13, 2025
+26 −14

Conversation

DrJosh9000
Copy link
Contributor

Description

Fixes bug introduced in #3238.

Context

https://linear.app/buildkite/issue/PS-554

Changes

  • Only apply disconnect-after-idle-timeout check if the ping did not yield a job.
  • Log if a job was yielded in states where it is unexpected (acquire-job, disconnect-after-job after job)

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 marked this pull request as ready for review May 13, 2025 04:42
@DrJosh9000 DrJosh9000 force-pushed the ps-554-agents-keeps-disconnecting branch from ad8c8c2 to 4df4487 Compare May 13, 2025 04:43
@DrJosh9000 DrJosh9000 force-pushed the ps-554-agents-keeps-disconnecting branch from 4df4487 to a55a4bc Compare May 13, 2025 04:44
wolfeidau
wolfeidau approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 great work spotting the issue.

@DrJosh9000 DrJosh9000 merged commit b870af6 into main May 13, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the ps-554-agents-keeps-disconnecting branch May 13, 2025 05:03
@DrJosh9000 DrJosh9000 mentioned this pull request May 13, 2025
Merged
@jeremybumsted jeremybumsted mentioned this pull request Jun 5, 2025
Merged
@moskyb moskyb mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @wolfeidau