-
Notifications
You must be signed in to change notification settings - Fork 105
Clarify persistent worker docs #9474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
00bf1e8
to
6b5c412
Compare
9e29b14
to
0f750c8
Compare
0f750c8
to
ad755a3
Compare
|
||
1. Set `"recycle-runner": "true"` in `exec_properties` to enable | ||
[runner recycling](#action-isolation-and-hermeticity-properties). | ||
We recommend setting this property using a Bazel macro, so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty annoying. Have you tried --modify_execution_info
? I'll take a look tomorrow, there has to be a better way than macro (if there isn't, we need to add one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think --modify_execution_info
can be used to set exec_properties
but let me know if you think otherwise. Side note - I could not find any bazel docs on what "execution info" actually is 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you are right. This actually works in the opposite direction: exec properties can end up as execution info, which is essentially a Bazel-internal tagging scheme for executions that subsumes things like no-remote-exec
tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strictly doc improvements that accurately described the state of things today. It’s a bit thorny, so i think we should address it with a future change and update this doc later.
LGTM
No description provided.