Skip to content

Clarify persistent worker docs #9474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify persistent worker docs #9474

wants to merge 2 commits into from

Conversation

bduffany
Copy link
Member

No description provided.

@bduffany bduffany requested a review from sluongng May 27, 2025 17:53
@bduffany bduffany force-pushed the rbe-docs-clarify branch from 00bf1e8 to 6b5c412 Compare May 27, 2025 17:55
@bduffany bduffany force-pushed the rbe-docs-clarify branch 2 times, most recently from 9e29b14 to 0f750c8 Compare May 27, 2025 18:54
@bduffany bduffany force-pushed the rbe-docs-clarify branch from 0f750c8 to ad755a3 Compare May 27, 2025 18:57

1. Set `"recycle-runner": "true"` in `exec_properties` to enable
[runner recycling](#action-isolation-and-hermeticity-properties).
We recommend setting this property using a Bazel macro, so that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty annoying. Have you tried --modify_execution_info? I'll take a look tomorrow, there has to be a better way than macro (if there isn't, we need to add one).

Copy link
Member Author

@bduffany bduffany May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think --modify_execution_info can be used to set exec_properties but let me know if you think otherwise. Side note - I could not find any bazel docs on what "execution info" actually is 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you are right. This actually works in the opposite direction: exec properties can end up as execution info, which is essentially a Bazel-internal tagging scheme for executions that subsumes things like no-remote-exec tags.

Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strictly doc improvements that accurately described the state of things today. It’s a bit thorny, so i think we should address it with a future change and update this doc later.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants