invocation_target_group_card: show cache status #9457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick preview |
sluongng
force-pushed
the
sluongng/show-test-target-cache-status
branch
2 times, most recently
from
43872ce to
439fd8b
Compare
|
With some manual AC deletion in local disk_cache, I was able to produce a cache miss for 1/3 shards. Worth noting that |
|
Hmm does |
sluongng
force-pushed
the
sluongng/show-test-target-cache-status
branch
from
439fd8b to
d791e0c
Compare
The Bazel log output only really shows |
fmeum
reviewed
May 23, 2025
sluongng
force-pushed
the
sluongng/show-test-target-cache-status
branch
from
d791e0c to
3d95baf
Compare
|
Hmm, I don't like the width increase for each of these run-grid items. |
bduffany
reviewed
May 27, 2025
sluongng
force-pushed
the
sluongng/show-test-target-cache-status
branch
2 times, most recently
from
fa274b4 to
b763e7f
Compare
Adds a badge next to the target label in the invocation targets list to display test cache status information. The badge shows "Cached" if all runs were served from cache. It shows "X cached / Y runs" if some runs were cached, where X is the number of cached runs and Y is the total number of runs. This case is relatively rare as test shards, runs and attempts usually share the same cache TTL. Nothing is displayed if no runs were cached. Note that we are not currently using test cache status to sort the target group. Such logic can be added later in a future change. Also, there is insufficient information from Build Event Stream to indicate whether a build target was cached or not, so all build targets are being shown without the badge, which could be misinterpreted as no-cache.
sluongng
force-pushed
the
sluongng/show-test-target-cache-status
branch
from
b763e7f to
432b067
Compare
fmeum
approved these changes
Jun 4, 2025
bduffany
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a badge next to the target label in the invocation targets
list to display test cache status information.
The badge shows "Cached" if all runs were served from cache.
Nothing is displayed if only some of the runs, or none were cached.
Note that we are not currently using test cache status to sort the
target group. Such logic can be added later in a future change. Also,
there is insufficient information from Build Event Stream to indicate
whether a build target was cached or not, so all build targets are being
shown without the badge, which could be misinterpreted as no-cache.