[Release] Fix version tag and commit not getting embedded correctly #4739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
maggie-lou
force-pushed
the
fix_version
branch
from
1481e5a to
2c836a4
Compare
maggie-lou
force-pushed
the
fix_version
branch
from
2c836a4 to
bb0df04
Compare
maggie-lou
requested review from
tylerwilliams,
vadimberezniker and
bduffany
bduffany
approved these changes
Sep 11, 2023
Unfortunately this doesn't fix the 'apps being double released problem'. If you do a dev push twice with the same target, the second one is a NOP. In our release flow we use two different targets though, and the apps are being re-pushed. More context here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit and version keep getting set to UNKNOWN in version.go, ruining our app version metric. There seems to be a bug where x_defs does not consistently embed the data during releases.
In this commit we try another approach where we use a genrule that explicitly sets stamp = 1 and directly reads from bazel-out/stable-status.txt (described here: bazelbuild/bazel#4942 (comment))
There's some additional context at the bottom of this thread: https://buildbuddy-corp.slack.com/archives/C01D5GHRJ59/p1694026279817119