Fix CEL bindings for maps for this variable
#278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
approved these changes
May 1, 2025
smaye81
changed the title
this variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the variable binding to
thisfor maps. Previously, the binding was using a map of the custom value abstractionObjectValuethat we use in protovalidate-java. ThisValueclass has no relation at all to CEL-Java'sValobject. So, using it as a variable binding does not work because CEL-Java doesn't know how to interpret it.This adds an additional
mapValueAsObjectfunction to return a map ofObjects for the binding. Note this not ideal, but should be sufficient for now. Further context in the comments.