New conformance fixes #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the string format library in favor of cel-cpp's standard implementation. This causes some tests to be fixed, but it also causes some new failures due to non-standard string formatting behavior in protovalidate. This will be fixed on the next protovalidate release, so we should probably release that and then update this PR with it before merging.
jchadwick-buf
force-pushed
the
jchadwick/conformance-fixes
branch
from
22e8dea to
f90853f
Compare
Alfus
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the string format library in favor of cel-cpp's standard implementation. This causes some tests to be fixed, but it also causes some new failures due to non-standard string formatting behavior in protovalidate. This will be fixed on the next protovalidate release, so we should probably release that and then update this PR with it before merging.