Update cel-cpp to v0.11.0 #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit complicated because cel-cpp v0.11.0 breaks WORKSPACE support a little bit, but thankfully the API we're using has remained relatively stable. Patches have been rebased, I'm pretty confident that I'll need to loop around to the MSVC patch to make sure it still works but the field access patch seems to be working first-try so knock-on-wood. The CMakeLists will need to be audited because I'm sure there's now stuff in it that should be removed, but let's focus on getting a working build first. We can focus on making the CMakeLists as accurate as possible when we're closer to being able to upstream it.
Alfus
approved these changes
Apr 16, 2025
|
let me know of you need any more changes to cel-cpp to get bzl working. |
|
no huge issues, but i should probably start submitting some upstream patches for next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit complicated because cel-cpp v0.11.0 breaks
WORKSPACEsupport a little bit, but thankfully the API we're using has remained relatively stable. Patches have been rebased, I'm pretty confident that I'll need to loop around to the MSVC patch to make sure it still works but the field access patch seems to be working first-try so knock-on-wood. The CMakeLists will need to be audited because I'm sure there's now stuff in it that should be removed, but let's focus on getting a working build first. We can focus on making the CMakeLists as accurate as possible when we're closer to being able to upstream it.Although cel-cpp now compiles with bzlmod, it has yet to be added to the BCR, so we might not be able to use it with bzlmod ourselves yet. (I'll be sure to double-check this, but I want to keep this PR clean.) Another follow-up item would be to use the
strings.formatimplementation provided by cel-cpp v0.11.0, but it will probably be according to the new spec, so that is pending on aprotovalidaterelease with the updated tests.Draft until we're passing in CI. I anticipate problems across platforms.