Simplify IPv6 parsing logic a little #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work around some edge cases with IPv6, I adopted a local state value that would ensure productions could only appear in specific states. However, the same problem is solved a bit more elegantly in bufbuild/protovalidate-go#215 by simply always ensuring that the state after successfully consuming a production can't be invalid. This means that we need to handle the following edge cases:
parseHexadecimalHexadecatet
already ensures that the production is not overly long and fails if it is.So I believe this is at least as correct as it was before, but is simpler.