Skip to content

[Feature Request] Add support for bzlmod #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Martin-Idel opened this issue Jan 20, 2025 · 2 comments · Fixed by #88
Closed

[Feature Request] Add support for bzlmod #66

Martin-Idel opened this issue Jan 20, 2025 · 2 comments · Fixed by #88
Labels
Feature New feature or request

Comments

@Martin-Idel
Copy link

Feature description:
Since Bazel switched to using bzlmod (and therefore MODULE.bazel) as the recommended way of dealing with repositories, protovalidate-cc should also support this. In addition, it would be nice to then add the repo into the bazel central registry.

Problem it solves or use case:
Use repository in modern bazel modules.

Contribution:
I can look into it, but I'm not too familiar with that side of Bazel myself, yet.

Examples or references:
protovalidate itself added support recently: https://github.com/bufbuild/protovalidate

@Martin-Idel Martin-Idel added the Feature New feature or request label Jan 20, 2025
@jchadwick-buf
Copy link
Member

Quick update here. We would love to add support for Bzlmod in protovalidate-cc. One potential blocker here is a lack of support in some of our dependencies; we'll need to make sure it's still possible for us to adopt bzlmod even if some of our dependencies have not. I have an inkling it might be possible using extensions, but I haven't tried.

We're hoping we can sort this out ahead of the Bazel 9 release later this year, but we don't have an exact timeframe for when this might be resolved; it might be sooner or later.

@jchadwick-buf
Copy link
Member

Support for this is about to be added as a part of #88, but it will still not be in the BCR yet, so you'll need to use a bazel_dep + an override rule to consume it for now. We'll probably tackle trying to get this into the BCR next release.

jchadwick-buf added a commit that referenced this issue Apr 22, 2025
I've held off on adding more CI to this for now, we can tackle that when
we tackle getting this on the BCR.

Note that cel-cpp is still not on the BCR; I'm not sure if this is a
blocker for us getting on the BCR. Still, it should be possible for
users to consume protovalidate-cc with bzlmod after this commit using
`bazel_dep` + `archive_override` just like we're doing for cel-cpp.

Closes #66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants