Skip to content

Fix invalid generation when using in-rule and not_in rule in map.keys.string #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2023
Merged

Fix invalid generation when using in-rule and not_in rule in map.keys.string #847

merged 4 commits into from
Apr 24, 2023

Conversation

ucpr
Copy link
Contributor

@ucpr ucpr commented Apr 22, 2023 •
edited
Loading

Summary

I fixed invalid generation for Go and cc when using in-rule and not_in rule in map.keys.string

Issue

Closes #785

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ucpr ucpr changed the title fix invalid generation for Go when using in-rule and not_in rule in map.keys.string Fix invalid generation for Go when using in-rule and not_in rule in map.keys.string Apr 22, 2023
@elliotmjackson
Copy link
Contributor

Thanks for the contribution @ucpr! Can you add a test case to the harness so that we can ensure this doesn't regress?

@ucpr ucpr changed the title Fix invalid generation for Go when using in-rule and not_in rule in map.keys.string Fix invalid generation when using in-rule and not_in rule in map.keys.string Apr 22, 2023
@ucpr
Copy link
Contributor Author

ucpr commented Apr 22, 2023

Hi @elliotmjackson!

I've added some test cases to the PR.
Adding the test case caused the C++ test to fail in the local environment. Therefore, I fixed it with Go in this PR.

@ucpr
Copy link
Contributor Author

ucpr commented Apr 22, 2023

Oh, test is failing. I will fix it.

@ucpr
Copy link
Contributor Author

ucpr commented Apr 23, 2023 •
edited
Loading

@elliotmjackson I fixed tests!

@ucpr
Copy link
Contributor Author

ucpr commented Apr 24, 2023

@elliotmjackson
CI has passed. Please review at your convenience 👍🏼

rodaine
rodaine approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@rodaine rodaine enabled auto-merge (squash) April 24, 2023 16:09
@rodaine rodaine merged commit c87857e into bufbuild:main Apr 24, 2023
@ucpr ucpr deleted the fix-issue-785 branch April 24, 2023 17:32
@ucpr ucpr mentioned this pull request Apr 28, 2023
Open
@mortezaPRK mortezaPRK mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodaine rodaine rodaine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golang invalid generation for map.keys.string in
4 participants
@ucpr @CLAassistant @elliotmjackson @rodaine