Skip to content

fix(bazel): make pgv compiler usable #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bazel/go/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
"""Define our protoc plugin in a rule that can be provided to go_proto_library#compilers

This is in a separate BUILD file from /bazel/BUILD to avoid a dependency on rules_go for all users who load from it.

If you use Gazelle, you can use a directive so that the pgv_plugin_go is automatically added to generated go_proto_library rules.
See https://github.com/bazelbuild/bazel-gazelle#directives

For example, in some/BUILD.bazel:
# gazelle:go_grpc_compilers @com_envoyproxy_protoc_gen_validate//bazel/go:pgv_plugin_go, @io_bazel_rules_go//proto:go_grpc
"""
load("@io_bazel_rules_go//proto:compiler.bzl", "go_proto_compiler")

go_proto_compiler(
name = "pgv_plugin_go",
suffix = ".pb.validate.go",
valid_archive = False,
plugin = "@com_envoyproxy_protoc_gen_validate//:protoc-gen-validate",
options = ["lang=go"],
visibility = ["//visibility:public"],
)
17 changes: 6 additions & 11 deletions bazel/pgv_proto_library.bzl
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
load("@io_bazel_rules_go//proto:compiler.bzl", "go_proto_compiler")
load("@io_bazel_rules_go//proto:def.bzl", "go_proto_library")
load("@rules_cc//cc:defs.bzl", "cc_library")
load(":protobuf.bzl", "cc_proto_gen_validate", "java_proto_gen_validate")

def pgv_go_proto_library(name, proto = None, deps = [], **kwargs):
go_proto_compiler(
name = "pgv_plugin_go",
suffix = ".pb.validate.go",
valid_archive = False,
plugin = "//:protoc-gen-validate",
options = ["lang=go"],
)
_DEFAULT_GO_PROTOC = ["@io_bazel_rules_go//proto:go_proto"]

def pgv_go_proto_library(name, compilers = _DEFAULT_GO_PROTOC, proto = None, deps = [], **kwargs):
go_proto_library(
name = name,
proto = proto,
deps = ["//validate:go_default_library"] + deps,
compilers = ["@io_bazel_rules_go//proto:go_proto", "pgv_plugin_go"],
deps = ["@com_envoyproxy_protoc_gen_validate//validate:validate"] + deps,
compilers = compilers + [
"@com_envoyproxy_protoc_gen_validate//bazel/go:pgv_plugin_go",
],
visibility = ["//visibility:public"],
**kwargs
)
Expand Down