Improve Development section of readme #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j178
reviewed
Oct 20, 2022
joshcarp
approved these changes
Oct 26, 2022
| ``` | ||
|
|
||
| [protoc-source]: https://github.com/google/protobuf | ||
|
|
There was a problem hiding this comment.
yeah, formatter
|
|
||
| ### Make Targets | ||
|
|
||
| - **`make build`**: generates the constraints proto and compiles PGV into `$GOPATH/bin` | ||
| - **`make build`**: generates the constraints proto and compiles PGV |
There was a problem hiding this comment.
yeah, formatter
elliotmjackson
added a commit
that referenced
this pull request
Nov 2, 2022
elliotmjackson
added a commit
that referenced
this pull request
Nov 2, 2022
elliotmjackson
added a commit
that referenced
this pull request
Nov 2, 2022
readme referenced `generate-testdata` which is a previous target in the makefile & `tests/go.mod` was malformed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlighted by our valued contributor @HaloWorld in #606, the
developmentsection of our readme needs some changes. This really does need a lot more work but should do the trick for now.resolves #690