TCN-464 Support GoReleaser on tag creation #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Jackson <[email protected]> Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
elliotmjackson
changed the title
joshcarp
approved these changes
Oct 17, 2022
akshayjshah
approved these changes
Oct 17, 2022
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.19.1 | ||
| cache: true |
There was a problem hiding this comment.
Can we at least use 1.19.x so we get the latest patch? This is already out of date.
| footer: | | ||
| ## Thanks! | ||
|
|
||
| Those were the changes on {{ .Tag }}! |
There was a problem hiding this comment.
Can we use the release notes template from connect-go? Github supports generating release notes automatically now, and they do a nice job highlighting new contributors.
(Fine to leave this config, or replace it with a message that these notes are temporary and should be replaced with GH's autogen.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR extends Github actions to include GoReleaser this will allow users to pull binaries directly from the release.