templates/java: add OuterClass suffix when conflict with all enums and messages #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafs99
force-pushed
the
cl/correct-outer-class-name
branch
3 times, most recently
from
a921306 to
eb88e74
Compare
…d messages According to https://developers.google.com/protocol-buffers/docs/reference/java-generated\#invocation, OuterClass suffix should be appended not only top-level but also nested enums and messages. Signed-off-by: leafs99 <[email protected]>
leafs99
force-pushed
the
cl/correct-outer-class-name
branch
from
eb88e74 to
6ded4c5
Compare
elliotmjackson
approved these changes
Sep 15, 2022
|
Thanks for your contribution @leafs99! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://developers.google.com/protocol-buffers/docs/reference/java-generated\#invocation,
OuterClass suffix should be appended not only top-level but also nested enums and
messages.
Signed-off-by: leafs99 [email protected]