C++: Fix polymorphic lookup and add tests #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous iteration does not make ASAN happy because of the implicit static cast between Message and concrete type. This PR reverts that change, adds a new abstract validation registry, and explicitly performs a dynamic cast when asked to do so. It also checks to make sure a validator exists for the passed in message. Also add a .clang-format so at least manual formatting can be done. Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
htuch
reviewed
Mar 3, 2022
Signed-off-by: Matt Klein <[email protected]>
|
@htuch updated per comments |
Signed-off-by: Matt Klein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous iteration does not make ASAN happy because of the implicit
static cast between Message and concrete type. This PR reverts that
change, adds a new abstract validation registry, and explicitly performs
a dynamic cast when asked to do so. It also checks to make sure a
validator exists for the passed in message.
Also add a .clang-format so at least manual formatting can be done.
Signed-off-by: Matt Klein [email protected]