Skip to content

Java: Support for osx-aarch_64 architecture #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2022
Merged

Java: Support for osx-aarch_64 architecture #569

merged 2 commits into from
Mar 2, 2022

Conversation

codebutler
Copy link
Contributor

Update the build system to generate artifacts for MacOS on ARM64
to support Apple Silicon / M1 machines.

@codebutler
Copy link
Contributor Author

Can someone please review this? @mattklein123

@mattklein123
Copy link
Contributor

Can you fix DCO please? Also, CI is failing so that will need to be fixed. I can rubber stamp this when fixed but I would prefer if @rmichela could actually take a look. Thank you.

@codebutler
Java: Support for osx-aarch_64 architecture
36ce2fe 
Update the build system to generate artifacts for MacOS on ARM64
to support Apple Silicon / M1 machines.

Signed-off-by: Eric Butler <[email protected]>
@codebutler codebutler force-pushed the osx-aarch_64 branch 2 times, most recently from 84f77a4 to 0085377 Compare March 1, 2022 19:54
@codebutler
update go to 1.17.7
f774a5e 
Signed-off-by: Eric Butler <[email protected]>
@codebutler
Copy link
Contributor Author

Can you fix DCO please?

Done!

Also, CI is failing so that will need to be fixed.

Fixed! (by updating go version in the circle ci config file)

I can rubber stamp this when fixed but I would prefer if @rmichela could actually take a look. Thank you.

👍 thanks! would be great if someone could confirm that the new artifact will be automatically uploaded to maven central with the next release, or if any other configuration changes are needed.

@mattklein123 mattklein123 merged commit d4f85cd into bufbuild:main Mar 2, 2022
@rmichela
Copy link
Contributor

rmichela commented Mar 2, 2022

Sorry for the delay. LGTM 🎉

@iampava
Copy link

iampava commented Mar 7, 2022 •
edited
Loading

Hey and thanks for this fix.

However, I can't find version v0.6.7 on maven: https://repo.maven.apache.org/maven2/io/envoyproxy/protoc-gen-validate/pgv-java-stub/. How could I add it as a dependency in pom.xml?

@rmichela
Copy link
Contributor

rmichela commented Mar 7, 2022

I'm planning to release to Maven today.

@huynq33
Copy link

huynq33 commented Mar 9, 2022 •
edited
Loading

@rmichela
2 days have passed, can you tell me when it will be released? I'm running a project that needs this support version for M1 chip

@huynq33
Copy link

huynq33 commented Mar 9, 2022

While waiting from new release version, i change JDK version (gradle version too) in my IDE (intelIJ) which doesn't support aarch_64, it works for me now. That why dependency doesn't add osx-aarch_64 to the end of file.
Screen Shot 2022-03-09 at 17 59 31
.

@donbeave donbeave mentioned this pull request Mar 9, 2022
Closed
@rmichela
Copy link
Contributor

Released to maven central as 0.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@rmichela rmichela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebutler @mattklein123 @rmichela @iampava @huynq33