proto field name to validation error #48 (Java) #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmichela
suggested changes
Feb 15, 2020
java/pgv-java-grpc/src/main/java/io/envoyproxy/pgv/grpc/ValidationExceptions.java
Outdated
Show resolved
Hide resolved
java/pgv-java-grpc/src/main/java/io/envoyproxy/pgv/grpc/ValidationExceptions.java
Outdated
Show resolved
Hide resolved
java/pgv-java-grpc/src/test/java/io/envoyproxy/pgv/grpc/ValidatingServerInterceptorTest.java
Outdated
Show resolved
Hide resolved
|
Can you also please rebase onto master? |
added 4 commits
February 16, 2020 13:07
Signed-off-by: Morten Løcka <[email protected]>
…details. Signed-off-by: Morten Løcka <[email protected]>
Signed-off-by: Morten Løcka <[email protected]>
Signed-off-by: Morten Løcka <[email protected]>
rmichela
approved these changes
Feb 19, 2020
|
For Java I'm happy to defer to @rmichela |
hexdigest
pushed a commit
to hexdigest/protoc-gen-validate
that referenced
this pull request
Mar 26, 2020
* Save fields in validation exception Signed-off-by: Morten Løcka <[email protected]> * ValidationException to StatusRuntimeException with BadRequest status details. Signed-off-by: Morten Løcka <[email protected]> * Extended tests with BadRequests details from validation exception Signed-off-by: Morten Løcka <[email protected]> * formatting and cleanup Signed-off-by: Morten Løcka <[email protected]> Signed-off-by: Maxim Chechel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A java implementation of #48