Skip to content

Remove hidden parallelism flag from app #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Remove hidden parallelism flag from app #3821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions private/pkg/app/appext/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"time"

"github.com/bufbuild/buf/private/pkg/app"
"github.com/bufbuild/buf/private/pkg/thread"
"github.com/pkg/profile"
"github.com/spf13/pflag"
)
Expand All @@ -40,8 +39,6 @@ type builder struct {
profileType string
profileAllowError bool

parallelism int

timeout time.Duration

defaultTimeout time.Duration
Expand Down Expand Up @@ -82,8 +79,6 @@ func (b *builder) BindRoot(flagSet *pflag.FlagSet) {
// We do not officially support this flag, this is for testing, where we need warnings turned off.
flagSet.BoolVar(&b.noWarn, "no-warn", false, "Turn off warn logging")
_ = flagSet.MarkHidden("no-warn")
flagSet.IntVar(&b.parallelism, "parallelism", 0, "Manually control the parallelism")
_ = flagSet.MarkHidden("parallelism")

// We used to have this as a global flag, so we still need to not error when it is called.
var verbose bool
Expand Down Expand Up @@ -126,10 +121,6 @@ func (b *builder) run(
}
container := newContainer(nameContainer, logger)

if b.parallelism > 0 {
thread.SetParallelism(b.parallelism)
}

var cancel context.CancelFunc
if !b.profile && b.timeout != 0 {
ctx, cancel = context.WithTimeout(ctx, b.timeout)
Expand Down