Skip to content

Fix excluded_type imports for implicitly excluded extensions #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2025

Conversation

emcfarlane
Copy link
Contributor

@emcfarlane emcfarlane commented Apr 3, 2025

This fixes exclude_type for an included extension which is implicitly excluded due to all fields being excluded.

Closes #3738

@emcfarlane emcfarlane requested a review from doriable April 3, 2025 16:28
Copy link
Contributor

github-actions bot commented Apr 3, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 3, 2025, 7:25 PM

@emcfarlane emcfarlane changed the title Assert excluded_type imported as a system error Fix excluded_type imports for excluded extensions Apr 3, 2025
@emcfarlane emcfarlane changed the title Fix excluded_type imports for excluded extensions Fix excluded_type imports for implicitly excluded extensions Apr 3, 2025
@emcfarlane emcfarlane merged commit c942c37 into main Apr 3, 2025
11 checks passed
@emcfarlane emcfarlane deleted the ed/excludeImportedSysError branch April 3, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude_types throws "imported file buf/validate/validate.proto was filtered out" error
2 participants