Update thread.ParallelizeWithCancel to thread.ParallelizeWithCancelOnFailure that no longer takes a context.CancelFunc

[bufdev]

thread.ParallelizeWithCancel would call a provided context.CancelFunc if any given job failed. However:

• All we wanted to do was make sure a cancel was sent to ctx on any job failure.
• Every time we called thread.ParallelizeWithCancel, we created the CancelFunc right before it:

// This is every call we made.
ctx, cancel := context.WithCancel(ctx)
defer cancel()
return thread.Parallelize(ctx, jobs, thread.ParallelizeWithCancel(cancel))

This was confusing and unnecessary - all we need to do is create a CancelFunc within Parallelize if we want this behavior.

This PR updates the option to do just this, along with a rename in line with this behavior.

[github-actions]

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	✅ passed	✅ passed	✅ passed	Aug 16, 2024, 8:07 PM