Skip to content

Fix close on write storage mappers #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix close on write storage mappers #3225

merged 1 commit into from
Aug 12, 2024

Conversation

emcfarlane
Copy link
Contributor

Param is missing on constructor, close isn't called.

@github-actions GitHub Actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 11, 2024, 11:51 AM

@emcfarlane emcfarlane requested a review from doriable August 12, 2024 14:25
bufdev
bufdev approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, not fantastic on my part from a long time ago

@emcfarlane emcfarlane merged commit 582997b into main Aug 12, 2024
13 checks passed
@emcfarlane emcfarlane deleted the ed/fixMapWriteCloser branch August 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufdev bufdev bufdev approved these changes

@doriable doriable Awaiting requested review from doriable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emcfarlane @bufdev